Skip to content

Update doxygen.yaml to set dependency on Flex#730

Merged
jcftang merged 1 commit intohashdist:masterfrom
chvillanuevap:master
Apr 30, 2015
Merged

Update doxygen.yaml to set dependency on Flex#730
jcftang merged 1 commit intohashdist:masterfrom
chvillanuevap:master

Conversation

@chvillanuevap
Copy link
Copy Markdown
Contributor

@chvillanuevap chvillanuevap commented Apr 24, 2015

Doxygen has a dependency on Flex. See build log here:

2015/04/23 21:57:58 - INFO: [package:run_job]   Autodetected platform linux-g++... 
2015/04/23 21:57:58 - INFO: [package:run_job]   Checking for GNU make tool... using /usr/bin/make
2015/04/23 21:57:58 - INFO: [package:run_job]   Checking for GNU install tool... using /usr/bin/install
2015/04/23 21:57:58 - INFO: [package:run_job]   Checking for dot (part of GraphViz)... using /usr/bin/dot
2015/04/23 21:57:59 - INFO: [package:run_job]   Checking for python... using /home/villanueva/.hashdist/bld/profile/7zzysldrvpy3/bin/python2
2015/04/23 21:57:59 - INFO: [package:run_job]   Checking for perl... using /usr/bin/perl
2015/04/23 21:57:59 - INFO: [package:run_job]   Checking for flex... not found!
2015/04/23 21:57:59 - ERROR: [package:run_job] Command '[u'/bin/bash', '_hashdist/build.sh']' returned non-zero exit status 1
2015/04/23 21:57:59 - ERROR: [package:run_job] command failed (code=1); raising

@jcftang
Copy link
Copy Markdown
Member

jcftang commented Apr 30, 2015

+1

jcftang added a commit that referenced this pull request Apr 30, 2015
@jcftang
Merge pull request #730 from chvillanuevap/master
07e4104 
Update doxygen.yaml to set dependency on Flex
@jcftang jcftang merged commit 07e4104 into hashdist:master Apr 30, 2015
certik
certik reviewed Apr 30, 2015
View reviewed changes
Comment thread pkgs/doxygen.yaml
Copy link
Copy Markdown
Member

@certik certik Apr 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should put a space after comma.

@chvillanuevap
Copy link
Copy Markdown
Contributor Author

chvillanuevap commented Apr 30, 2015

Is that a coding standard, or will it break things?

I was able to build Doxygen on Ubuntu 14.04.

@jcftang
Copy link
Copy Markdown
Member

jcftang commented Apr 30, 2015

@chvillanuevap It's more of a style thing

@certik
Copy link
Copy Markdown
Member

certik commented Apr 30, 2015

Just like in Python code you put spaces after commas, it's a good idea here as well. It doesn't change any functionality, it's just a style.

@chvillanuevap
Copy link
Copy Markdown
Contributor Author

chvillanuevap commented Apr 30, 2015

I started a new pull request with this change:

#738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chvillanuevap @jcftang @certik